Handle structs explicitly when adding error type #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to avoid assuming that all errors reasons are either nil or structs. This rearranges the clauses and uses pattern matching to handle the struct case, allowing us to handle anything else like we handled the nil case before.
aselder
approved these changes
Feb 21, 2021
|
Running Would really love to see the PR merged 👍 |
|
Excellent, thanks so much for taking the time to submit a PR for this, @cararemixed and also @vovayartsev for confirming that it's working well! 🚀 |
GregMefford
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to avoid assuming that all errors reasons are either nil or structs. This rearranges the clauses and uses pattern matching to handle the struct case, allowing us to handle anything else like we handled the nil case before.