-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MSC 1929 Homeserver Admin Contact #1931
Conversation
Fixes spantaleev#1612 For details to the proposed (not accepted yet) MSC, see: https://github.com/matrix-org/matrix-spec-proposals/blob/hs/proposal-admin-contact-1/proposals/1929-admin-contact.md
roles/matrix-base/templates/static-files/well-known/matrix-support.j2
Outdated
Show resolved
Hide resolved
Idea from moanos in the matrix room for
|
roles/matrix-base/templates/static-files/well-known/matrix-support.j2
Outdated
Show resolved
Hide resolved
Thank you for the constructive feedback @spantaleev - I tried to address your suggestions in the latest commit. |
7845be3
to
91cca1b
Compare
Related to #1931 `|to_json` already adds the surrounding double-quotes for the string, so adding them explicitly means we've got a double-quotes problem.
Related to #1931 This does 2 things: - it fixes the syntax for `matrix_id`. Starting strings with `@` is invalid YAML, so such strings need to be wrapped in single or double quotes - it makes use of the `matrix_domain` variable instead of hardcoding the domain name. This should be more and mistake-proof (typos or people mistaking their domain - matrix. vs base domain)
Thanks! 👍 I've merged it, but had to do some post-merge fixes:
I've also added a variable ( Because matrix-org/matrix-spec-proposals#1929 is not yet accepted, I've defaulted the new |
Fixes #1612
For details to the proposed (not accepted yet) MSC, see:
https://github.com/matrix-org/matrix-spec-proposals/blob/hs/proposal-admin-contact-1/proposals/1929-admin-contact.md