[jruby] Different behaviour between jruby nokogiri and C nokogiri when formatting xml

[tychobrailleur]

When formatting xml, JRuby Nokogiri has a different behaviour to the C extension:

greystones:/tmp $ cat test.rb
require 'nokogiri'

doc = Nokogiri::XML("<foo>bar</foo>") do |c|
  c.noblanks
end

puts doc.to_xml(indent: 2)

When using the C extension:

greystones:/tmp $ rvm use 1.9.3
Using /home/sebastien/.rvm/gems/ruby-1.9.3-p194
greystones:/tmp $ ruby test.rb 
<?xml version="1.0"?>
<foo>bar</foo>

the text node is compact, i.e. displayed without whitespace around.

When using the Java extension:

greystones:/tmp $ rvm use jruby-head
Using /home/sebastien/.rvm/gems/jruby-head
greystones:/tmp $ ruby test.rb 
<?xml version="1.0"?>
<foo>
  bar
</foo>

the text node is on its own line, indented, with no way of compacting it.

The discrepancy causes apps that produces XML behave differently with MRI and JRuby.

[jvshahid]

hi @tychobrailleur, thanks for reporting the bug and fixing it. Can you open a pull request so I can merge your test case and the fix ? Thanks.

[jvshahid]

nm, i found the pull request.

[tychobrailleur]

@jvshahid Sorry, I should have given a reference to the PR here. For the record, here is the pull request: #772

[yokolet]

@tychobrailleur Thanks for the fix.