-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nokogiri sax error handlers get fscked up when using libxml #87
Comments
Oh shit. This sucks. I'm sorry, I'll see what I can do to either circumvent libxml-ruby, or at the very least, document the problem. |
Unfortunately there isn't anything I can do about this problem. Libxml-ruby is setting a global C variable when you call that ruby method. Since I can't stop you from calling that ruby code, there isn't much I can do about this except document the problem. |
thanks for looking into it. it's interesting, actually I don't call any method in libxml-ruby, just requiring it causes the problem. i expect some sort of global hook being used by libxml-ruby on being required to be the problem |
changing the global error function on SAX load. closed by d23fe2c |
This was leading to loss of error capture on extremely short HTML docs when encoding was not passed by the caller. This call was introduced in d23fe2c (#87) for reasons that are unclear, but we've come a long way with how we manage the global error handlers and so I think we're OK to stop doing this now.
This was leading to loss of error capture on extremely short HTML docs when encoding was not passed by the caller. This call was introduced in d23fe2c (#87) for reasons that are unclear, but we've come a long way with how we manage the global error handlers and so I think we're OK to stop doing this now.
This was leading to loss of error capture on extremely short HTML docs when encoding was not passed by the caller. This call was introduced in d23fe2c (#87) for reasons that are unclear, but we've come a long way with how we manage the global error handlers and so I think we're OK to stop doing this now.
http://pastie.org/520797
as demonstrated requiring libxml stuffs up nokogiri's error handlers. this is especially difficult to trace if your application is using nokogiri but one of the plugin uses libxml-ruby. this is not a bug per-se in nokogiri but i would like to see this ironed out or atleast listed as an issue in the documentation.
The text was updated successfully, but these errors were encountered: