Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in test suite. #1141

Merged
merged 3 commits into from
Jan 15, 2015
Merged

Conversation

kylev
Copy link

@kylev kylev commented Jul 29, 2014

This resolves all the ruby errors that spit out when running the test suite. Minor, but annoying.

/Users/kylev/Work/nokogiri/test/html/test_document.rb:224: warning: ambiguous first argument; put parentheses or even spaces
/Users/kylev/Work/nokogiri/test/html/test_document.rb:239: warning: ambiguous first argument; put parentheses or even spaces
/Users/kylev/Work/nokogiri/test/html/test_document.rb:251: warning: ambiguous first argument; put parentheses or even spaces
/Users/kylev/Work/nokogiri/test/html/test_document.rb:252: warning: ambiguous first argument; put parentheses or even spaces
/Users/kylev/Work/nokogiri/test/html/test_document.rb:258: warning: ambiguous first argument; put parentheses or even spaces
/Users/kylev/Work/nokogiri/test/xml/test_builder.rb:17: warning: assigned but unused variable - builder
/Users/kylev/Work/nokogiri/test/xml/test_document.rb:57: warning: ambiguous first argument; put parentheses or even spaces
/Users/kylev/Work/nokogiri/test/xml/test_document.rb:379: warning: method redefined; discarding old test_prepend_child_fragment_with_multiple_nodes
/Users/kylev/Work/nokogiri/test/xml/test_document.rb:371: warning: previous definition of test_prepend_child_fragment_with_multiple_nodes was here
/Users/kylev/Work/nokogiri/test/xml/test_entity_reference.rb:29: warning: ambiguous first argument; put parentheses or even spaces
/Users/kylev/Work/nokogiri/test/xml/test_node.rb:861: warning: ambiguous first argument; put parentheses or even spaces

This feeble penance is offered in hope for assistance on #1138, which I haven't yet managed to debug and fix. 😈

Kyle VanderBeek added 3 commits July 28, 2014 20:01
These typically happen when a potential operator like - or / start the
first argument. The fix is to make it unambiguous that you're doing a call,
not a math expression.
@leejarvis
Copy link
Member

✨ thanks!

leejarvis added a commit that referenced this pull request Jan 15, 2015
@leejarvis leejarvis merged commit 7639db5 into sparklemotion:master Jan 15, 2015
@kylev kylev deleted the kv_fix_warnings branch January 15, 2015 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants