[jruby] reduce generated noise + review touched code #1585
Closed
+75
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//XMLDocumentFilter[] filters = { removeNSAttrsFilter, elementValidityCheckFilter};
the registry was not thread-safe and would likely to have caused issues -> its best to re-invent the piece on a green field when necessary
kares
force-pushed
the
jruby-review-2
branch
2 times, most recently
from
9a7f6d1 to
5d07b41
Compare
commented -> when needed uncommenting won't do the crazy conversions
kares
force-pushed
the
jruby-review-2
branch
2 times, most recently
from
09d96f7 to
00819fd
Compare
|
Merging manually. Thank you so much! |
|
thanks. managed to cause a regression - with last commit. sorry about that will redo and open another PR next week (feel free to revert if needed). once again sorry for the mess-up should have used 2 branches or waited with the PR. |
|
ah so that commit shouldnt be here, mobile gh confused me. all should be fine, if by any chance not than I will look into it. thanks for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... after #1563 I did find some more bits worth improving/cleaning up
p.s. tried to keep the commits minimal (for easier reviewing) but feel free to squash on merge if preferred