Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeSet#each to return self instead of zero #1823

Merged
merged 2 commits into from
Dec 1, 2018
Merged

NodeSet#each to return self instead of zero #1823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6ecfc0
return self in the env of each
olehif Nov 30, 2018
e3ade9a
add test
olehif Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/nokogiri/xml/node_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ def each(&block)
0.upto(length - 1) do |x|
yield self[x]
end
self
end

###
Expand Down
6 changes: 6 additions & 0 deletions test/xml/test_node_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,12 @@ def awesome! ; end
assert_equal node_set.document, new_set.document
assert new_set.respond_to?(:awesome!)
end

def test_each_should_return_self
node_set1 = @xml.css("address")
node_set2 = node_set1.each {}
assert_equal node_set1, node_set2
end
end
end
end