Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate XML::ElementContent to the TypedData API #2814

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Migrate XML::ElementContent to the TypedData API #2814

merged 2 commits into from
Mar 6, 2023

Conversation

etiennebarrie
Copy link
Contributor

Ref #2808

@etiennebarrie etiennebarrie force-pushed the typeddata-xml-element-content branch from 42c1573 to 64d8c71 Compare March 6, 2023 11:05
@flavorjones
Copy link
Member

This LGTM but I'm going to take this opportunity to clean up some of the tests and the docstrings for this and the related classes.

@flavorjones flavorjones merged commit 34bac70 into sparklemotion:main Mar 6, 2023
@flavorjones
Copy link
Member

Thank you, @etiennebarrie !

@flavorjones flavorjones mentioned this pull request Mar 6, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etiennebarrie @flavorjones