Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example in installation docs doesn't work #81

Closed
jamesrhester opened this issue Sep 5, 2023 · 3 comments
Closed

Example in installation docs doesn't work #81

jamesrhester opened this issue Sep 5, 2023 · 3 comments

Comments

@jamesrhester
Copy link

This is part of the JOSS review openjournals/joss-reviews#5618.

The example in the installation documentation doesn't work. After pip install matbench-genmetrics into a new Python 3.11 virtual environment, I have the following:

In [1]: from mp_time_split.utils.gen import DummyGenerator
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 from mp_time_split.utils.gen import DummyGenerator

ModuleNotFoundError: No module named 'mp_time_split'

which is presumably a missing module required for the example.

In any case, the next line also fails to work.

In [2]: from matbench_genmetrics.core import MPTSMetrics10, MPTSMetrics100, MPTSMetrics1000, MPTSMetrics10000
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Cell In[2], line 1
----> 1 from matbench_genmetrics.core import MPTSMetrics10, MPTSMetrics100, MPTSMetrics1000, MPTSMetrics10000

ImportError: cannot import name 'MPTSMetrics10' from 'matbench_genmetrics.core' (/home/jrh/programs/JOSS/matbench-genmetrics/lib/python3.11/site-packages/matbench_genmetrics/core/__init__.py)
@jamesrhester
Copy link
Author

Looks to be easily fixed by replacing the text with contents of scripts/core/matbench_genmetrics_basic.py

@sgbaird
Copy link
Member

sgbaird commented Mar 19, 2024

@jamesrhester, this has been updated

@jamesrhester
Copy link
Author

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants