Show accurate list of supported drivers when throwing CannotCreateDbDumper exception
#1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a non-existent connection in
config('backup.backup.source.databases'), it will throw theCannotCreateDbDumperexception. The current exception message states that only the default Laravel connection names are supported, which is misleading. In reality, any connection defined inconfig('database.connections')can be used, regardless of whether it is a standard Laravel connection name or not.This PR modifies the exception message to display the actual available connection names that can be used. This will help users better understand which connections are valid options and reduce confusion.