Add support for checking backups on filesystem disks #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for checking backups on any filesystem you have defined in your Laravel installation. Including for example an S3 bucket.
The syntax is very simple. Something like this works with spatie/laravel-backup when backups are saved to S3:
I needed to create a new file
BackupFile.php
to abstract away the filesystem fromSymfonyFile
that you used before. This was the best solution to make this backwards compatible and support the glob style syntax in->locatedAt()
. When using Filesystem disk glob is not available and therefore that is not supported when using a Laravel disk.In the next major version I would suggest to stop using
SymfonyFile
and only use the Laravel FIlesystem. I think that is probably the right way to do this. With the filter option below, we can restore all current functionality.Questions:
locatedAt
?->filterFilesUsing(fn ($path) => preg_match('/backup\/[0-9-]+\.zip/', $path)
. I can add that if you think it is a good idea.I can also update the docs if you want.