Fixes errant reference to Health facade - should be Check facade - when creating macros for health checks #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies the macro should be defined in the Check facade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the macro should be defined using the Check facade
Per the original PR that added this feature, the examples given and code updated all appear to be targeting the Check class: #184
That Check class contains the
Macroabletrait - and the Health class does not appear to - using the Health class throws an error:Call to undefined method Spatie\Health\Health::macro()If there's any context I'm missing, happy to update this doc with more context on how to get these macros working properly.