Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw an exception when checking hasAllPermissions() #2248

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Don't throw an exception when checking hasAllPermissions() #2248

merged 1 commit into from
Nov 19, 2022

Conversation

mtawil
Copy link
Contributor

@mtawil mtawil commented Nov 17, 2022

I believe this change must be the same as the hasAnyPermission functionality as it coded here.
Also, throwing an error while we expect a boolean value doesn't make sense.

@drbyte drbyte changed the title Don't throw an exception when checking permission Don't throw an exception when checking hasAllPermissions() Nov 17, 2022
@drbyte
Copy link
Collaborator

drbyte commented Nov 19, 2022

Thanks!

@drbyte drbyte merged commit 76dd153 into spatie:main Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtawil @drbyte