Appending attributes based on scope

[chelout]

Hi, i'm looking into using package in my project and have a question about appending attributes.
I'd like to add conditional attributes to response based on query result.

Let's say i have Post model with comments relation

class Post extends Model {
    public function comments()
    {
        return $this->morphToMany(Comment::class, 'commentable');
    }

    public function scopeWithCommentsStatistics(Builder $query)
    {
        $query->/** Some complex query, which counts additional columns **/
    }

    public function getCommentsStatisticsAttribute()
    {
        return [
            // additional columns from withCommentsStatistics() scope
        ];
    }
}

I can get posts list from PostController like this:

class PostController extends Controller
{
    public function index()
    {
        $posts = QueryBuilder::for(Post::class)
            ->allowedFilters([
                AllowedFilter::scope('comments_statistics', 'withCommentsStatistics'),
            ])
            ->allowedAppends(['comments_statistics'])
            ->get();

        return PostResourceCollection::make($deals);
    }
}

With following request /post?filter[comments_statistics]=1&append=comments_statistics

So the question is there any way to get my comments_statistics attribute with only /post?append=comments_statistics?

It could be done applying withCommentsStatistics() scope to all queries, like global scope, but i don't feel like having complex part of query in all queries that works with Post model.

Thanks!

[AlexVanderbist]

Hi! I'm not sure we can easily achieve something like this using just appended attributes in this package. The query builder actually only builds queries, allowing appended attributes to be added using this package might've been a mistake 😅

Probably not the answer you were looking for but I'd suggest using Laravel's API resources to achieve this: https://laravel.com/docs/master/eloquent-resources. Using a resource you can conditionally add a couple of statistics fields whenever the fields are loaded in the query. This will probably cleanup your code quite a bit as well.

Good luck!