Check also attributes on methods when checking whether an attribute should be allowed in methods #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould be allowed in methods. A disallowed attribute used on a method (or on a function) is technically not in the method, so `$scope->getFunction()` returns null and thus no attributes could be returned. Now the original node is passed around and used to get the reflection to get the attributes. Close #303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A disallowed attribute used on a method (or on a function) is technically not in the method, so
$scope->getFunction()returns null and thus no attributes could be returned. Now the original node is passed around and used to get the reflection to get the attributes.Close #303