-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back default values for the SPDX default model store #284
Comments
Since the default model store is in core and the CopyManager and InMemSpdxStore are in the higher level library, we'll probably need to initialize the default model store in the |
Why wasn't |
In any case, it would be nice to have |
Unless it should also be possible for the application to provide a different model store? |
How about creating 2 init methods, one that passes in the parameters to Another complication would be if we called init twice - currently there is no impact on multiple calls. Since we may be changing the state of the |
I'll create a PR with the above proposed solution. |
@dwalluck I'm rethinking the second init method with the default model store parameters. See #286 (comment) for reasoning. |
See #237 (comment) for discussion.
The text was updated successfully, but these errors were encountered: