Create an IndividualElement class #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow individuals to be of a type that can be instantiated and could resolve the issue with SHACL validation failing spdx/spec-parser#165
|
See this conversation in #936 for context |
|
This might make it kinda hard to know how named individuals are supposed to be used; I think maybe we can deal with it if necessary but I need to do some testing before we go ahead and make this change |
|
Ah, you know what, I was think of enums. This should be fine |
|
We'll need this PR (or an alternative) if we continue to restrict instantiating abstract classes in SHACL, so changing this as ready for review. |
This was referenced Dec 10, 2024
Merged
bact
requested changes
Dec 10, 2024
bact
requested changes
Dec 10, 2024
Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: Alexios Zavras (zvr) <[email protected]>
zvr
requested changes
Dec 10, 2024
bact
approved these changes
Dec 10, 2024
|
Approved, providing the suggested "for Core profile" by @zvr is added to the Description. |
Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: Gary O'Neall <[email protected]>
|
@zvr - Accepted suggestion - if you could approve and merge everything should be working. |
zvr
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow individuals to be of a type that can be instantiated and could resolve the issue with SHACL validation failing spdx/spec-parser#165