Profile hardware - Draft Hardware Profile Submission #947

stevenc-stb · 2024-12-21T18:00:41Z

This is the draft hardware submission. Please review and advise.

Signed-off-by: stevenc-stb <[email protected]>

Need to move to model/Core/Vocabularies/processType.md Signed-off-by: stevenc-stb <[email protected]>

Signed-off-by: stevenc-stb <[email protected]>

Add new Relationship Types Signed-off-by: stevenc-stb <[email protected]>

Signed-off-by: stevenc-stb <[email protected]>

Improved clarity Signed-off-by: stevenc-stb <[email protected]>

Signed-off-by: stevenc-stb <[email protected]>

Improved Clarity. Signed-off-by: stevenc-stb <[email protected]>

Signed-off-by: stevenc-stb <[email protected]>

Clarity Signed-off-by: stevenc-stb <[email protected]>

Signed-off-by: stevenc-stb <[email protected]>

Fix coordinateOrientationType Signed-off-by: stevenc-stb <[email protected]>

Moved to model/Core/Vocabularies/processType.md Signed-off-by: stevenc-stb <[email protected]>

move to /Core/Vocabularies/processType.md Signed-off-by: stevenc-stb <[email protected]>

bact · 2024-12-21T18:24:02Z

@stevenc-stb You can put this PR out of draft anytime you feel ready, so one of the maintainers can merge it. Thank you.

zvr

I'm not marking typos, etc. in descriptions; these can be fixed later.

zvr · 2024-12-22T12:53:35Z

model/Core/Classes/Process.md

@@ -0,0 +1,36 @@
+SPDX-License-Identifier: Community-Spec-1.0
+
+# Process


This is very confusing.
There is a definition of Process, which is a set of tasks (not found elsewhere), and its status is a document State ?
More explanation is needed, in the text, I think.
And why is it in /Core ?

FuSa and Hardware profiles in the current discussion will need the class. Where should it go if two profiles need it?
i will put the definition of Process on the to-do list for improvement .

zvr · 2024-12-22T12:55:24Z

model/Core/Properties/status.md

+
+## Description
+
+Draft, active, obsolete or other are used to define the state or status of a proceedure.


It seems this uses "state" and "status" interchangeably. Can you standardize in one?

zvr · 2024-12-22T12:56:35Z

model/Core/Properties/typeOfProcess.md

@@ -0,0 +1,17 @@
+SPDX-License-Identifier: Community-Spec-1.0
+
+# typeOfProcess


Our usual naming conventions would have it as processType.

We are trying to avoid having the property name and the vocabulary name having the same name.

model/Core/Vocabularies/documentState.md

model/Core/Vocabularies/processType.md

zvr · 2024-12-22T13:06:31Z

model/Hardware/Hardware.md

+the following has to hold:
+
+
+1. for every `/Hardware/Hardware` The property listed under the physical are not available if virtualFlag = true


I think it would be better to have different classes, VirtualHardware and PhysicalHardware (or whatever you want to name them) and have the corresponding properties in the corresponding classes. You may have an abstract Hardware superclass for the common properties.

We will discuss this issue with the HBOM group January 10. What is the main reason for your suggestion?

zvr · 2024-12-22T13:09:50Z

model/Hardware/Properties/informationElementList.md

@@ -0,0 +1,17 @@
+SPDX-License-Identifier: Community-Spec-1.0
+
+# informationElementList


We'd usually call it simply informationElement, not adding "List"

model/Hardware/Properties/organizationalEntity.md

model/Hardware/Vocabularies/coordinateOrientationType.md

Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Signed-off-by: stevenc-stb <[email protected]>

Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

bact

I have put some individual suggestions, please take a look at each of them.

All of them are just suggestions.

The Hardware Profile group may like to discuss this further and may like to put it otherwise -- happy to approve this for now so there can be something on the branch for discussion further.

model/Hardware/Vocabularies/CoordinateOrientationType.md

model/Core/Vocabularies/DocumentState.md

model/Core/Vocabularies/RelationshipType.md

model/Hardware/Classes/HBOMDimensions.md

model/Hardware/Vocabularies/CoordinateOrientationType.md

Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Signed-off-by: stevenc-stb <[email protected]>

Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Signed-off-by: stevenc-stb <[email protected]>

bact · 2025-01-07T17:15:30Z

model/Hardware/Properties/centerofMass.md

@@ -0,0 +1,17 @@
+SPDX-License-Identifier: Community-Spec-1.0
+
+# centerofMass


Suggested change

# centerofMass

# centerOfMass

Should this be centerOfMass (Of with big O), the same as typeOfProcess ?

bact · 2025-01-07T17:22:06Z

I can see that we are starting have more properties related to value+unit (mass+massUnit and dimensions+dimensionsUnit here, energyQuantity+energyUnit in AI), may be in 3.1 we consider patterns used in https://schema.org/QuantitativeValue ?

stevenc-stb added 29 commits December 19, 2024 15:08

Add Process Obect for HBOM

75be2c5

Signed-off-by: stevenc-stb <[email protected]>

Add files via upload

b111d39

Signed-off-by: stevenc-stb <[email protected]>

Add Hardware Class Profile

f7b92b0

Signed-off-by: stevenc-stb <[email protected]>

Update Hardware.md

cdc9d0b

Signed-off-by: stevenc-stb <[email protected]>

Update and rename xAxis.md to xAxisLength.md

a9c466c

Signed-off-by: stevenc-stb <[email protected]>

Update and rename yAxis.md to yAxisLength.md

aee5e70

Signed-off-by: stevenc-stb <[email protected]>

Update and rename zAxis.md to zAxisLength.md

b6d82c6

Signed-off-by: stevenc-stb <[email protected]>

Update HBOMDimensions.md - Change ()Axis to ()AxisLength

6f33d08

Signed-off-by: stevenc-stb <[email protected]>

Update HBOMDimensions.md Fix Capulization

4165756

Signed-off-by: stevenc-stb <[email protected]>

Delete model/Hardware/Vocabularies/processType.md

2c56078

Need to move to model/Core/Vocabularies/processType.md Signed-off-by: stevenc-stb <[email protected]>

Add processType to Core

9d5191e

Signed-off-by: stevenc-stb <[email protected]>

Update Process.md

131f964

Signed-off-by: stevenc-stb <[email protected]>

Update and rename type.md to typeOfProcess.md

f0dc396

Signed-off-by: stevenc-stb <[email protected]>

Update Process.md

8a0bb7e

Signed-off-by: stevenc-stb <[email protected]>

Delete model/Hardware/Vocabularies/documentState.md

c930806

Signed-off-by: stevenc-stb <[email protected]>

Add Document State to the right place.

72bfbef

Signed-off-by: stevenc-stb <[email protected]>

Update RelationshipType.md

3300866

Add new Relationship Types Signed-off-by: stevenc-stb <[email protected]>

Update RelationshipType.md

47944eb

Signed-off-by: stevenc-stb <[email protected]>

Update RelationshipType.md

e724862

Signed-off-by: stevenc-stb <[email protected]>

Update physical.md

719c075

Signed-off-by: stevenc-stb <[email protected]>

Update status.md

2c37e9b

Improved clarity Signed-off-by: stevenc-stb <[email protected]>

Update RelationshipType.md

25ff6f6

Signed-off-by: stevenc-stb <[email protected]>

Update informationElementList.md

00d0f4d

Improved Clarity. Signed-off-by: stevenc-stb <[email protected]>

Update physical.md

b35b37c

Signed-off-by: stevenc-stb <[email protected]>

Update virtualFlag.md

ce6ba53

Clarity Signed-off-by: stevenc-stb <[email protected]>

Update virtualFlag.md

5dbf526

Signed-off-by: stevenc-stb <[email protected]>

Update coordinateOrientationType.md

e1427b2

Fix coordinateOrientationType Signed-off-by: stevenc-stb <[email protected]>

Delete model/Hardware/Vocabularies/processType.md

89c926c

Moved to model/Core/Vocabularies/processType.md Signed-off-by: stevenc-stb <[email protected]>

Add files via upload

6db3db4

move to /Core/Vocabularies/processType.md Signed-off-by: stevenc-stb <[email protected]>

bact added the Profile:Hardware Hardware Profile and related matters label Dec 21, 2024

bact requested a review from kestewart December 21, 2024 18:22

zvr requested changes Dec 22, 2024

View reviewed changes

stevenc-stb and others added 12 commits December 23, 2024 07:33

Update model/Hardware/Classes/HBOMPhysical.md

2adc10b

Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Update documentState.md

7cdb584

Signed-off-by: stevenc-stb <[email protected]>

Rename documentState.md to DocumentState.md

27ce819

Signed-off-by: stevenc-stb <[email protected]>

Update and rename processType.md to ProcessType.md

f529397

Signed-off-by: stevenc-stb <[email protected]>

Update Process.md

d20a189

Signed-off-by: stevenc-stb <[email protected]>

Update coordinateOrientationType.md

ff12907

Signed-off-by: stevenc-stb <[email protected]>

Rename coordinateOrientationType.md to CoordinateOrientationType.md

bebfaa1

Signed-off-by: stevenc-stb <[email protected]>

Update HBOMDimensions.md

a422636

Signed-off-by: stevenc-stb <[email protected]>

Update coordinateOrientation.md

4e4f569

Signed-off-by: stevenc-stb <[email protected]>

Update status.md

96a1c83

Signed-off-by: stevenc-stb <[email protected]>

Update model/Hardware/Classes/Hardware.md

e074c7d

Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Update model/Hardware/Classes/HBOMPhysical.md

5d84b8c

Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

bact approved these changes Dec 23, 2024

View reviewed changes

stevenc-stb and others added 9 commits December 23, 2024 08:51

Update model/Core/Vocabularies/DocumentState.md

e74e271

Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Update model/Hardware/Classes/HBOMDimensions.md

1be8552

Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Update model/Core/Vocabularies/RelationshipType.md

4d8790a

Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Update Hardware.md

5857a1d

Signed-off-by: stevenc-stb <[email protected]>

Update organizationalEntity.md

1182b0c

Signed-off-by: stevenc-stb <[email protected]>

Update model/Hardware/Vocabularies/CoordinateOrientationType.md

984532c

Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Update model/Hardware/Vocabularies/CoordinateOrientationType.md

2cf3ea2

Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Update model/Hardware/Vocabularies/CoordinateOrientationType.md

b5233e1

Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

Update model/Hardware/Vocabularies/CoordinateOrientationType.md

63c9dc7

Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: stevenc-stb <[email protected]>

stevenc-stb marked this pull request as ready for review December 23, 2024 16:21

stevenc-stb added 2 commits December 23, 2024 11:20

Update organizationalEntity.md

38749c4

Signed-off-by: stevenc-stb <[email protected]>

Update organizationalEntity.md

d646159

Signed-off-by: stevenc-stb <[email protected]>

bact reviewed Jan 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Profile hardware - Draft Hardware Profile Submission #947

Profile hardware - Draft Hardware Profile Submission #947

stevenc-stb commented Dec 21, 2024

bact commented Dec 21, 2024

zvr left a comment

zvr Dec 22, 2024

stevenc-stb Dec 27, 2024

zvr Dec 22, 2024

zvr Dec 22, 2024

stevenc-stb Dec 23, 2024 •

edited

Loading

zvr Dec 22, 2024

stevenc-stb Dec 23, 2024

zvr Dec 22, 2024

bact left a comment

bact Jan 7, 2025

bact commented Jan 7, 2025

		@@ -0,0 +1,36 @@
		SPDX-License-Identifier: Community-Spec-1.0

		# Process


		## Description

		Draft, active, obsolete or other are used to define the state or status of a proceedure.

		@@ -0,0 +1,17 @@
		SPDX-License-Identifier: Community-Spec-1.0

		# typeOfProcess

		the following has to hold:


		1. for every `/Hardware/Hardware` The property listed under the physical are not available if virtualFlag = true

		@@ -0,0 +1,17 @@
		SPDX-License-Identifier: Community-Spec-1.0

		# informationElementList

		@@ -0,0 +1,17 @@
		SPDX-License-Identifier: Community-Spec-1.0

		# centerofMass

Profile hardware - Draft Hardware Profile Submission #947

Are you sure you want to change the base?

Profile hardware - Draft Hardware Profile Submission #947

Conversation

stevenc-stb commented Dec 21, 2024

bact commented Dec 21, 2024

zvr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevenc-stb Dec 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bact left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bact commented Jan 7, 2025

stevenc-stb Dec 23, 2024 •

edited

Loading