-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chinese translation for models - Part I #948
base: support/3.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add few 。at the end of entry descriptions, for consistency with the English version and other Simplified Chinese instances.
The translations should be based on support/3.0 (see the branch descriptions). |
Thanks for the review, I will rebase to 3.0 branch |
Add Chinese translation for AI and Build models Signed-off-by: Zhenyu Zheng <[email protected]>
cf1a13d
to
3f84502
Compare
Hi, rebased to support/3.0 and comments addressed |
Thanks @ZhengZhenyu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that extra blank line, I think this looks good to me. Thank you.
Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: Zhenyu Zheng <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
I am not qualified to review the content, as I cannot read Chinese, but for the structure of the files, LGTM. |
@ZhengZhenyu Thanks for the translations! Do you know someone in the community who can review the content? They can just leave a comment in the PR's. |
Hi Thanks for the reviews, the content is actually done by group from various entities in China, because they are lawyers and translators so it was done and reviewed offline, and I was preparing to add thier names to the contributors list in the main repo after this is merged. I'm not sure whether they have github account or not. Is it mandantory to leave comments here our can I provide the list? |
|
Thank you. We should give credit to these names somewhere on our spec website. |
Thanks, @ZhengZhenyu . 1, all the contributors, which seems to be the one you provided As you wrote, the first list should be added to our list of contributors in the spec repo. Please note that we only use names, not titles, so I suggest you submit it like:
(which lines will of course be merged in different places, since we keep the list alphabetical by first name). But for this repo, we'd like to know the second list of GitHub accounts. |
Add Chinese translation for AI and Build models