Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation for models - Part I #948

Open
wants to merge 3 commits into
base: support/3.0
Choose a base branch
from

Conversation

ZhengZhenyu
Copy link

Add Chinese translation for AI and Build models

@bact bact added the Translation:zh-Hans Translation for Simplified Chinese label Jan 2, 2025
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add few 。at the end of entry descriptions, for consistency with the English version and other Simplified Chinese instances.

model/AI/Properties/autonomyType.md Outdated Show resolved Hide resolved
model/AI/Vocabularies/EnergyUnitType.md Outdated Show resolved Hide resolved
model/Build/Build.md Outdated Show resolved Hide resolved
@bact
Copy link
Collaborator

bact commented Jan 2, 2025

@goneall @zvr which branch this translation PR should be targeted to? develop or support/3.0 ?

@goneall
Copy link
Member

goneall commented Jan 2, 2025

The translations should be based on support/3.0 (see the branch descriptions).

@ZhengZhenyu
Copy link
Author

Thanks for the review, I will rebase to 3.0 branch

@ZhengZhenyu ZhengZhenyu changed the base branch from develop to support/3.0 January 3, 2025 02:12
Add Chinese translation for AI and Build models

Signed-off-by: Zhenyu Zheng <[email protected]>
@ZhengZhenyu
Copy link
Author

Hi, rebased to support/3.0 and comments addressed

@goneall
Copy link
Member

goneall commented Jan 3, 2025

Hi, rebased to support/3.0 and comments addressed

Thanks @ZhengZhenyu

Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that extra blank line, I think this looks good to me. Thank you.

model/Build/Build.md Outdated Show resolved Hide resolved
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Zhenyu Zheng <[email protected]>
model/Build/Build.md Outdated Show resolved Hide resolved
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested review from zvr, goneall and kestewart January 5, 2025 03:54
@bact
Copy link
Collaborator

bact commented Jan 5, 2025

I am not qualified to review the content, as I cannot read Chinese, but for the structure of the files, LGTM.

@goneall
Copy link
Member

goneall commented Jan 5, 2025

@ZhengZhenyu Thanks for the translations! Do you know someone in the community who can review the content? They can just leave a comment in the PR's.

@ZhengZhenyu
Copy link
Author

@ZhengZhenyu Thanks for the translations! Do you know someone in the community who can review the content? They can just leave a comment in the PR's.

Hi Thanks for the reviews, the content is actually done by group from various entities in China, because they are lawyers and translators so it was done and reviewed offline, and I was preparing to add thier names to the contributors list in the main repo after this is merged. I'm not sure whether they have github account or not. Is it mandantory to leave comments here our can I provide the list?

@ZhengZhenyu
Copy link
Author

  • 陈锐昕 Ruixin CHEN, openEuler G11N SIG member, openEuler social media content contributor
  • 方晓 Christian Xiao FANG, Senior IP Counsel at the Media Group
  • 高亮 Kubi Liang GAO, OpenHarmony Compliance SIG leader
  • 郭雪雯 Vanessa Xuewen GUO, Legal Counsel at the OpenAtom Foundation
  • 何春燕 Chunyan HE, openEuler G11N SIG maintainer, openEuler social media content contributor
  • 康宝丹 Baodan KANG, openEuler social media content contributor, Huawei Technologies Co., Ltd
  • 刘鹏 Peng LIU, openEuler G11N SIG maintainer, openEuler social media content contributor
  • 刘珊 Shan LIU, openEuler G11N SIG maintainer, openEuler social media content contributor
  • 欧轩琦 Xuanqi OU, Doctor of Science
  • 王静 Jing WANG, openEuler social media content contributor, Huawei Technologies Co., Ltd
  • 文静 Jing WEN, Senior Engineer
  • 薛杨洁 Hazel Yangjie XUE, Legal Counsel at the OpenAtom Foundation
  • 张维瑜 Weiyu ZHANG, openEuler G11N SIG maintainer, openEuler social media content contributor
  • 郑振宇 Zhenyu ZHENG, openEuler Operation Working Group leader
  • 周舟 Jojo Zhou ZHOU, Senior IP Counsel at the Media Group
    Here is the list of the group work on these contents.

@bact
Copy link
Collaborator

bact commented Jan 7, 2025

Thank you. We should give credit to these names somewhere on our spec website.

@zvr
Copy link
Member

zvr commented Jan 7, 2025

Thanks, @ZhengZhenyu .
As you realized, we're talking about two lists:

1, all the contributors, which seems to be the one you provided
2. all the people who will actively participate via GitHub in submitting, reviewing, and merging content.

As you wrote, the first list should be added to our list of contributors in the spec repo. Please note that we only use names, not titles, so I suggest you submit it like:

Christian Xiao FANG (方晓), 
Kubi Liang GAO (高亮), 
Vanessa Xuewen GUO (郭雪雯), 
Chunyan HE (何春燕), 
Baodan KANG (康宝丹), 
Peng LIU (刘鹏), 
Shan LIU (刘珊), 
Xuanqi OU (欧轩琦), 
Jing WANG (王静), 
Jing WEN (文静), 
Hazel Yangjie XUE (薛杨洁), 
Weiyu ZHANG (张维瑜), 
Zhenyu ZHENG (郑振宇), 
Jojo Zhou ZHOU, (周舟), 

(which lines will of course be merged in different places, since we keep the list alphabetical by first name).

But for this repo, we'd like to know the second list of GitHub accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation:zh-Hans Translation for Simplified Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants