Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new generateLicenseXml algo and script to beautify the xml #132

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Add new generateLicenseXml algo and script to beautify the xml #132

merged 1 commit into from
Aug 27, 2019

Conversation

Ugtan
Copy link
Collaborator

@Ugtan Ugtan commented Aug 12, 2019 •
edited
Loading

Fixes #100, and Fixes #45

@goneall
Copy link
Member

goneall commented Aug 23, 2019

@Ugtan It looks like there are a few tests failing with this PR (e.g. Test for adding, editing and deleting attributes using split view tree editor ... ERROR). Do the tests pass locally on your machine? If not, please fix the issues so that all unit tests pass.

@Ugtan Ugtan force-pushed the issues/100 branch 2 times, most recently from 4350eec to 97e4ab0 Compare August 23, 2019 19:08
@Ugtan
Copy link
Collaborator Author

Ugtan commented Aug 23, 2019

Hello @goneall and @techytushar
I have fixed the tests that were failing and I think everything is good to go. I have tested it and it seems to be working fine please take a look and lemme know if its good to go. This PR will also fix issue #45. Thanks

goneall
goneall approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall
Copy link
Member

goneall commented Aug 23, 2019

@techytushar If this looks good to you, I'll go ahead and merge.

techytushar
techytushar approved these changes Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@techytushar techytushar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM!!

@goneall goneall merged commit 76fbd2b into spdx:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techytushar techytushar techytushar approved these changes

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Ugtan @goneall @techytushar