[issue-290] refactor data model #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoweidner
force-pushed
the
issue-290-refactor-data-model
branch
2 times, most recently
from
e26db6f to
fcac984
Compare
armintaenzertng
requested changes
Nov 21, 2022
nicoweidner
force-pushed
the
issue-290-refactor-data-model
branch
4 times, most recently
from
e0a0014 to
b9c3456
Compare
armintaenzertng
approved these changes
Nov 22, 2022
Signed-off-by: Nicolaus Weidner <[email protected]>
Signed-off-by: Nicolaus Weidner <[email protected]>
Signed-off-by: Nicolaus Weidner <[email protected]>
Signed-off-by: Nicolaus Weidner <[email protected]>
Signed-off-by: Nicolaus Weidner <[email protected]>
Signed-off-by: Nicolaus Weidner <[email protected]>
nicoweidner
force-pushed
the
issue-290-refactor-data-model
branch
from
3022dbe to
2a3a80c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290
Rewritten data model, hopefully clearer in particular with regards to types. It's fairly minimal so far, we can add more utility later (e.g. more magic functions)
Note: As soon as the Python min version is officially 3.7, we can check whether dataclasses can reduce some of the annoying duplication involved in writing constructors, for example.