Identify Invalid SPDX File format and Invalid Tag Value file as different error. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent error. *Add a new Exception InvalidFileFormatException for all invalid spdx supported file formats. *Pass on correct error to enclosing function to identify invalid file or invalid tag value file or rdf file. Signed-off-by: rtgdk <[email protected]>
goneall
requested changes
Jul 20, 2017
Signed-off-by: rtgdk <[email protected]>
|
@goneall Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new Exception InvalidFileFormatException for catching all invalid files which are not tag value or rdf files and thrown the exception where all invalid Files were failing in
BuildDocument.checkAnalysisNull.Also when handling expection I have separated, all the three exception in all the enclosing function -
Invalid file type -
InvalidFileFormatException,Invalid Tag Value File -
InvalidSpdxTagFileException,Invalid RDF or any other file not caught by the above exception -
Exception( Default Exception )When in
CompareSPDXDocs.convertTagValueToRdfthe first two exception are caught and thrown asSpdxCompareExceptionwhich result in terminating the function and show proper error. This way, these two types of file will not be passed as RDF Files in later function.Only Invalid RDF, Valid RDF or any other file not caught by the first two exception are passed in the second function to check for RDF files.