LicenseExpressionParser: Allow "+" as part of license-refs #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goneall My contributions are done under the terms of the Apache License, version 2.0. |
license-refs as defined in Appendix IV of the SPDX 2.0 specification should be allowed to contain "+", e.g. to write "LicenseRef-LGPL-3.0+". Currently, LicenseExpressionParser interprets "+" in license-refs as Operator.OR_LATER even if they are no compound-expression. Fix this by checking the compound-expression for a license-ref and do not take "+" as a token in that case.
sschuberth
force-pushed
the
license-ref
branch
from
c5f07b6 to
fe0f239
Compare
|
Closing this as it needs more work (like checking the SPDX version) but I currently have no time or strong interest to work on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
license-refs as defined in Appendix IV of the SPDX 2.0 specification
should be allowed to contain "+", e.g. to write "LicenseRef-LGPL-3.0+".
Currently, LicenseExpressionParser interprets "+" in license-refs as
Operator.OR_LATER even if they are no compound-expression. Fix this by
checking the compound-expression for a license-ref and do not take "+" as
a token in that case.