Fix for bug of the function is_json_mimetype() (#1541)

* Fix for bug of the function is_json_mimetype() (#1114) * Splitting the mimetype correctly * Added a test for the json mimetype usecases * Update connexion/utils.py Co-authored-by: Ruwann <[email protected]>
spec-first · May 31, 2022 · b561ecf · b561ecf
1 parent be492f9
commit b561ecf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/connexion/utils.py b/connexion/utils.py
@@ -136,7 +136,10 @@ def is_json_mimetype(mimetype):
     :type mimetype: str
     :rtype: bool
     """
+
     maintype, subtype = mimetype.split('/')  # type: str, str
+    if ';' in subtype:
+        subtype, parameter = subtype.split(';', maxsplit=1)
     return maintype == 'application' and (subtype == 'json' or subtype.endswith('+json'))
 
 

diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -60,3 +60,11 @@ def test_deep_get_dict():
 def test_deep_get_list():
     obj = [{'type': 'object', 'properties': {'id': {'type': 'string'}}}]
     assert utils.deep_get(obj, ['0', 'properties', 'id']) == {'type': 'string'}
+
+
+def test_is_json_mimetype():
+    assert utils.is_json_mimetype('application/json')
+    assert utils.is_json_mimetype('application/vnd.com.myEntreprise.v6+json')
+    assert utils.is_json_mimetype('application/vnd.scanner.adapter.vuln.report.harbor+json; version=1.0')
+    assert utils.is_json_mimetype('application/vnd.com.myEntreprise.v6+json; charset=UTF-8')
+    assert not utils.is_json_mimetype('text/html')