Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(core/webidl): remove legacy TreatNullAs #2851

Merged
merged 1 commit into from
Apr 23, 2020
Merged

test(core/webidl): remove legacy TreatNullAs #2851

merged 1 commit into from
Apr 23, 2020

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Apr 22, 2020 •
edited
Loading

This attribute was removed in whatwg/webidl#870 and one of our test was using it (see failing test).

@sidvishnoi sidvishnoi requested a review from saschanaz April 22, 2020 10:25
@sidvishnoi sidvishnoi merged commit 42cc58e into develop Apr 23, 2020
@sidvishnoi sidvishnoi deleted the tests/remove-legacy-TreatNullAs branch April 23, 2020 08:45
@saschanaz
Copy link
Collaborator

saschanaz commented Apr 23, 2020 •
edited
Loading

It's not removed, it's just renamed to LegacyNullToEmptyString. Still LGTM though.

sidvishnoi added a commit that referenced this pull request May 23, 2020
@sidvishnoi
test(core/webidl): remove legacy TreatNullAs (#2851)
d1b7d35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

@saschanaz saschanaz Awaiting requested review from saschanaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidvishnoi @saschanaz @marcoscaceres