Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entering Cat # in loan preparation dialog for nonconsolidated COGs works incorrectly #6141

Open
emenslin opened this issue Jan 22, 2025 · 1 comment · May be fixed by #6145
Open

Entering Cat # in loan preparation dialog for nonconsolidated COGs works incorrectly #6141

emenslin opened this issue Jan 22, 2025 · 1 comment · May be fixed by #6145
Assignees
@melton-jason
Labels
2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more geospecify
Milestone
7.10

Comments

@emenslin
Copy link
Collaborator

Describe the bug
Introduced in #6038, catalog numbers that are part of a nonconsolidated COG are treated the same as ones that are part of a consolidated COG in the preparation dialog. If you type in a catalog number that is part of a nonconsolidated COG, on the next page any other children of that COG will show up

To Reproduce
Steps to reproduce the behavior:

  1. Create a COG with a type that is not consolidated
  2. Add multiple childCOs with preparations
  3. Open loan dialog
  4. Type in one of the catalog numbers
  5. Click next
  6. See all other childCOs get carried over

Expected behavior
If the CO is part of a COG that is not consolidated the other childCOs should not show up in the dialog.

Screenshots

01-22-2025_14.26.mp4

Please fill out the following information manually:
@emenslin emenslin added 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more geospecify labels Jan 22, 2025
@emenslin emenslin added this to the 7.10 milestone Jan 22, 2025
@melton-jason
Copy link
Contributor

melton-jason commented Jan 22, 2025 •
edited
Loading

This might be in part because of a problem introduced via merges in Apply COG sibling logic to loan returns #6038. Here's what happened:

This bug is likely the result of having the code from #6061 being introduced into production.
Even if this direct bug is not caused because of the incorrect merge, we should remove the unintentional changes and implement them later in #6061

@melton-jason melton-jason linked a pull request Jan 23, 2025 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melton-jason melton-jason

Labels
2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more geospecify
Projects
None yet
Milestone
7.10
Development

Successfully merging a pull request may close this issue.

Remove changes in production from #6061 specify/specify7
2 participants
@melton-jason @emenslin