Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changes in production from #6061 #6145

Open
wants to merge 8 commits into
base: production
Choose a base branch
from
Open

Conversation

melton-jason
Copy link
Contributor

@melton-jason melton-jason commented Jan 23, 2025

Should fix #6141

This might be in part because of a problem introduced via merges in Apply COG sibling logic to loan returns #6038. Here's what happened:

This bug is likely the result of having the code from #6061 being introduced into production. Even if this direct bug is not caused because of the incorrect merge, we should remove the unintentional changes and implement them later in #6061

From #6141 (comment)

Here's what I did to resolve this:

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)

Testing instructions

@specify/developers

@specify/ux-testing

Ensure that everything from #6038 is functional. Here are the testing instructions from #6038 (comment):

  • Create a new consolidated COG. Go to http://localhost/specify/view/collectionobjectgroup/new/, set the name, then set the cogType to consolidated. Save.
  • Add a new child CO with a new prep. Set the count to 2.
  • Repeat: Add a new child CO with a new prep. Set the count to 2.
  • Save.
  • Create a new loan, use the catalog numbers from the new COs so that both of the new preps are in the loan preps.
  • Set the loan number to something random.
  • Save.
  • Click 'Return Loan'.
  • Select the first loan prep only. Set the quantity returned and quantity resolved to 1.
  • Save.
  • Refresh page.
  • See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
  • Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

==> The purpose of these tests is to verify that the count returned is set to the maximum, whatever the number entered by the user + verify that all siblings of a prep CO that is a part of a consolidated COG are also returned to they max.

@melton-jason melton-jason added this to the 7.10 milestone Jan 23, 2025
@melton-jason melton-jason requested review from acwhite211 and a team January 23, 2025 00:43
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • While testing, ensure that no feature from Apply COG sibling logic to loan returns #6038 (comment) is present
  • See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
  • Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

Looks good! Behvaior seems to be reverted.

@emenslin emenslin requested a review from a team January 23, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

Entering Cat # in loan preparation dialog for nonconsolidated COGs works incorrectly
4 participants