Migrate off backbone.js and jQuery #4339
Draft
+212
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpatiiuk
commented
Jan 1, 2024
| table: tables[tableName], | ||
| id, | ||
| }; | ||
| const resource: SavedResource<TABLE_NAME> = { ...ref, ref, data }; |
There was a problem hiding this comment.
ref includes table and id properties
it is useful to have these properties on the resource
but, it may also be useful to be able to quickly get from resource back to resource ref, so the ref property exists
if it turns out to be redundant/needless, we could remove it (in favor of doing { table: resource.table, id: resource.id } - which could be a helper function resourceToRef)
note, resource ref objects are not globally unique - but, their contents (table name + id pair) resolve to one resource only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begun work on #4286. Read comments in that issue for architecture details and justification - feedback is welcome