-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default query mapping path to filter by COT tree def in QB search #6142
Conversation
Triggered by 6285dcb on branch refs/heads/issue-6098
Triggered by 88b2d63 on branch refs/heads/issue-6098
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Since the queryBuilderFieldPath
overrides the field
, this can probably be simplified by removing the queryBuilderFieldPath
from the QueryComboBoxFilter type and instead allowing the field
to be an Array of strings (MappingPath).
e.g., change
readonly field: string & (keyof CommonFields | keyof SCHEMA['fields']); |
to
readonly field: MappingPath | (string & (keyof CommonFields | keyof SCHEMA['fields']));
(And handling the case when field
is an Array in toQueryFields
)
@melton-jason The text search filter expects specify7/specifyweb/frontend/js_src/lib/components/SearchDialog/index.tsx Lines 142 to 151 in 9cd74f2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify there is already a mapping line for filtering by COT tree def
Just want to check this is the correct behavior before approving but all ranks show up even if they are not part of the tree you are querying on. This isn't necessarily a problem but it could just potentially be confusing so I wanted to double check.
01-23-2025_10.07.mp4
@emenslin Yeah that is expected. The mapping line should ensure Taxon that don't belong to the COT don't show up in the results |
Fixes #6098
Checklist
self-explanatory (or properly documented)
Testing instructions