Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated UserInfocard.vue file #1076

Conversation

Narayan1670
Copy link
Contributor

Horizontal Scrolling was not working because of the parent container width was small than the image container.

Fix: resolves Horizontal Scrolling was not working properly.

Description & motivation

The parent container width was not enough to contain the image.
Fixes #1039

Changes:

In specklesystems/speckle-server/blob/main/packages/frontend/src/main/components/user/UserInfoCard.vue
replaced ,ax-widthfrom 400 to 500 on line 85.

Screenshots:

before

after

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Reference

Horizontal Scrolling was not working because of the parent container width was small than the image container.
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 88.86% // Head: 88.86% // No change to project coverage 👍

Coverage data is based on head (e55c858) compared to base (393a192).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         144      144           
  Lines        4671     4671           
  Branches      262      262           
=======================================
  Hits         4151     4151           
  Misses        413      413           
  Partials      107      107           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@didimitrie didimitrie requested a review from fabis94 October 5, 2022 10:56
@didimitrie didimitrie added the hacktoberfest A collection of "good first issues" for hacktoberfest. label Oct 5, 2022
@fabis94 fabis94 self-assigned this Oct 5, 2022
Copy link
Contributor

@fabis94 fabis94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's not quite clear to me why it's exactly 500px and not 400px that resolves this issue, but judging from my own testing it seems to work

@fabis94 fabis94 merged commit 9a64a24 into specklesystems:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest A collection of "good first issues" for hacktoberfest.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cropping profile picture doesn't work horizontally
3 participants