Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Bubbles WASD Fix #3920

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Comment Bubbles WASD Fix #3920

merged 2 commits into from
Feb 3, 2025

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Handles https://linear.app/speckle/issue/WEB-2591/comment-bubbles-hang-on-on-the-screen-when-wasd-ing by handling https://linear.app/speckle/issue/WEB-2590/projection-query-should-report-out-of-frustum-somehow

  • PointQueryResult now has an inFrustum property which tells if the result is in the camera's frustum
  • The frontend uses this new property to determine if comment bubbles need to be occluded tested and displayed at all
  • An extra advantage is that we won't be doing extra intersection tests for comment bubbles that are not in view

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

…he requested point is in frustum when projecting and unprojecting
…tion step to account for their anchor's inclusion in the camera's frustum
Copy link

linear bot commented Jan 31, 2025

Copy link
Contributor

📸 Preview service has generated an image.

@AlexandruPopovici AlexandruPopovici merged commit cff48b9 into main Feb 3, 2025
28 of 30 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/WEB-2590 branch February 3, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants