Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-2466 fix(automate): include workspace in function breadcrumb #3926

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

cdriesler
Copy link
Member

Description & motivation

  • The current breadcrumb for /functions/:id does not respond when functions belong to a workspace:
    • There is no crumb for the parent workspace
    • The link to functions goes to /functions when it should go to /workspaces/:slug/functions

Changes:

  • Fetches workspace information for header, if relevant
  • Updates header breadcrumb based on presence of an owning workspace or not
  • Minor changes to createFunctionWithoutVersion (only used for admin/testing things)

Private function in a workspace:

Screen Shot 2025-02-03 at 17 55 57

Public function outside of a workspace:

Screen Shot 2025-02-03 at 17 56 26

Validation of changes:

This is...difficult to test locally:

  • Get automate running locally
  • Configure server to point to it
  • In apollo studio / explorer:
    • Create an empty function with the AutomateMutations.createFunctionWithoutVersion mutation
    • Update that function with AutomateMutations.updateFunction and a value for workspaceIds
  • Navigate to /functions/:functionId in either case and observe the changes

@cdriesler cdriesler changed the title fix(automate): include workspace in function breadcrumb WEB-2466 fix(automate): include workspace in function breadcrumb Feb 4, 2025
Copy link

linear bot commented Feb 4, 2025

@cdriesler cdriesler merged commit 272c136 into main Feb 4, 2025
26 of 28 checks passed
@cdriesler cdriesler deleted the charles/workspaceFunctionBreadcrumb branch February 4, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants