Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: types compilation of packages using tsup #322

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: types compilation of packages using tsup #322

merged 1 commit into from
Dec 2, 2024

Conversation

marcocondrache
Copy link
Contributor

This PR resolves #321

It disables tsc by using dts feature of tsup.

@marcocondrache marcocondrache mentioned this pull request Dec 1, 2024
Closed
@oscartbeaumont oscartbeaumont merged commit d105045 into specta-rs:main Dec 2, 2024
@marcocondrache marcocondrache mentioned this pull request Dec 2, 2024
Closed
@oscartbeaumont oscartbeaumont mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscartbeaumont oscartbeaumont oscartbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: types are not correctly generated for packages using tsup
2 participants
@marcocondrache @oscartbeaumont