Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test timeouts #643

Closed
raniejade opened this issue Mar 3, 2019 · 1 comment · Fixed by #647
Closed

Test timeouts #643

raniejade opened this issue Mar 3, 2019 · 1 comment · Fixed by #647
Labels
is: feature
Milestone
2.0.3

Comments

@raniejade
Copy link
Member

Spek executes tests serially in a single thread, any rogue tests that blocks indefinitely can cause the whole execution to block. Introducing an execution timeout per test will help stop that from happening.

  • timeouts should be configurable globally and a per test basis.
  • timeouts should only be applied to logic that participate in the execution phase: fixtures and test scopes.

Implementation details:

  • beforeEachTest, afterEachTest and the test itself is considered as a single unit, so the timeout is applied to their combined execution time.
  • beforeGroup and afterGroup timeout semantics is undefined for now.
@raniejade raniejade added this to the 2.1.0 milestone Mar 3, 2019
@raniejade
Copy link
Member Author

(tentatively slating it for 2.1.0)

This was referenced Mar 3, 2019
Closed
Merged
@raniejade raniejade modified the milestones: 2.1.0, 2.0.3 Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is: feature
Projects
None yet
Milestone
2.0.3
Development

Successfully merging a pull request may close this issue.

Implement test timeouts spekframework/spek
1 participant
@raniejade