Implement test timeouts #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raniejade
commented
Mar 6, 2019
| @@ -49,14 +51,23 @@ kotlin { | |||
|
|
|||
| linuxMain { | |||
| dependsOn nativeMain | |||
| dependencies { | |||
| implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core-native:1.1.1' | |||
There was a problem hiding this comment.
dependencies.gradle does not work here for some reason.
raniejade
commented
Mar 6, 2019
integration-test/src/jvmTest/kotlin/org/spekframework/spek2/integration/TimeoutTest.kt
Show resolved
Hide resolved
raniejade
commented
Mar 6, 2019
| @@ -15,6 +15,7 @@ pluginManagement { | |||
| } | |||
|
|
|||
| enableFeaturePreview('STABLE_PUBLISHING') | |||
| enableFeaturePreview('GRADLE_METADATA') | |||
There was a problem hiding this comment.
required by the coroutines library.
|
While debugging, I'm not able to take my time as this timeout occurs. I'm using the Gherkin method, so where can I override the timeout? And isn't there a way to set the timeout globally? |
|
@boylenssen just filed #692 and will be included in |
| val test = TestScopeImpl( | ||
| idFor(description), | ||
| root.path.resolve(description), | ||
| root, | ||
| defaultTimeout, |
There was a problem hiding this comment.
you want to use the argument here instead
There was a problem hiding this comment.
yep, already fixed in master.
There was a problem hiding this comment.
so I have this:
class ResponseTest : Spek({
setArchTaskExecutor()
timeout(15000)
but that doesn't work. How to I set it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #643
An optional timeout parameter is added to
testscope builder which defaults to 10 seconds. Timeout is implemented using coroutines under the hood, this means that timeout is not working on KN (only a single threaded coroutine is supported). Also, note that timeouts do not apply tobeforeGroup,afterGroupandafterEachTest.