Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish JS dsl artifacts #741

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Publish JS dsl artifacts #741

merged 1 commit into from
Jul 4, 2019

Conversation

raniejade
Copy link
Member

Resolves #706

@raniejade raniejade merged commit 5c78bd9 into 2.x Jul 4, 2019
@raniejade raniejade deleted the rr-publish-js-dsl branch July 4, 2019 09:36
@robstoll
Copy link
Contributor

@raniejade I tried it out for KBox, worked as expected. However, for Atrium it does not. It fails with Its dependency 'kotlin' was not found. even though other modules are loaded before hand and include the same check if (typeof kotlin === 'undefined') { .... I guess the problem comes from different JS module systems but that's only a guess. Just something you can keep in mind in case you start implementing a runner for JS (I could contribute as well in case you can need help)

@raniejade
Copy link
Member Author

I guess the problem comes from different JS module systems but that's only a guess.

Can you explain more? I'll see if I can think of something.

@robstoll
Copy link
Contributor

I am referring to this https://kotlinlang.org/docs/reference/js-modules.html
The tests in Atrium require to use commonjs in order that mocha can pick up the tests

@raniejade
Copy link
Member Author

Hmmm, weird. The JS artifact is published as an UMD module so it should be compatible with common js.

@robstoll
Copy link
Contributor

robstoll commented Aug 29, 2019

yeah... it should be, I remember that I ran into similar problems already. Maybe a Kotlin bug, I'll file an issue and see what they are saying (https://youtrack.jetbrains.com/issue/KT-33611)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide JS and Native api artifacts
2 participants