Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce fixture aliases for Gherkin style #818

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Introduce fixture aliases for Gherkin style #818

merged 2 commits into from
Nov 8, 2019

Conversation

jcornaz
Copy link
Contributor

@jcornaz jcornaz commented Oct 24, 2019

Hi,

This PR Resolves #799

Done during Basel HackerGarten with: @marvinbuff and @AdrianAgr

Hope you'll like it and find it helpful.

Copy link
Member

@raniejade raniejade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for the PR. Can you rewrite the test to not use kotlin-test? See https://github.com/spekframework/spek/tree/2.x/integration-test/src/jvmTest/kotlin/org/spekframework/spek2 for examples. Put them in the same package as well :)

@jcornaz
Copy link
Contributor Author

jcornaz commented Nov 4, 2019

@raniejade

I moved the tests to integration-test as requested.

However, do you know that they are not evaluated?

You can easily get convinced that there is a problem by going at the following line:

(on the main branch: 2.x)

Change the expected value (of 1 by 42) and run the tests (./gradlew jvmTest). The build is successful!

@raniejade
Copy link
Member

@jcornaz thanks for the report! I'll take a look at it, pretty sure it was working before.

Copy link
Member

@raniejade raniejade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the test not working, everything else is looking good. I'll merge this and just investigate the test issue. Thanks for the contribution!

@raniejade raniejade merged commit 72ef370 into spekframework:2.x Nov 8, 2019
@raniejade
Copy link
Member

@jcornaz found the issue (not really an issue)

Change the expected value (of 1 by 42) and run the tests (./gradlew jvmTest). The build is successful!

To run the spek tests please use jvmSpekTest the reason it's different is because the integration-test module is using the Spek's experimental gradle plugin.

@jcornaz jcornaz deleted the feature/fixture-aliases branch November 16, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce fixture aliases in gherkin style
2 participants