libadf: silence false-positive clang static analyzer warnings

clang warns about leaks when adf_find_nodes() takes an error-recovery path and returns ret >= 0. This is only possible if readdir() or sscanf() set errno <= 0 on error, which POSIX says can't happen. Bug: 27125399 Change-Id: I57ea312419efcac01f5721d07fc578a298bce2ea Signed-off-by: Greg Hackmann <[email protected]>
spezi77 · Mar 25, 2016 · 897a898 · 897a898
1 parent e16e82f
commit 897a898
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/adf/libadf/adf.c b/adf/libadf/adf.c
@@ -50,6 +50,10 @@ static ssize_t adf_find_nodes(const char *pattern, adf_id_t **ids)
 
         if (matched < 0) {
             ret = -errno;
+#if __clang_analyzer__
+            if (ret >= 0)
+                __builtin_unreachable();
+#endif
             goto done;
         } else if (matched != 1) {
             continue;
@@ -65,8 +69,13 @@ static ssize_t adf_find_nodes(const char *pattern, adf_id_t **ids)
         ids_ret[n] = id;
         n++;
     }
-    if (errno)
+    if (errno) {
         ret = -errno;
+#if __clang_analyzer__
+        if (ret >= 0)
+            __builtin_unreachable();
+#endif
+    }
     else
         ret = n;