Fix WriteConfig (#430, #433) #936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please, I need this so much! |
|
Ugh still not merged. Any reason? |
|
Hello, is there something I can do to get this PR merged? |
|
Ping? |
|
@spf13 we need this. |
yann-soubeyrand
force-pushed
the
master
branch
from
8dfc478 to
a97213d
Compare
|
Hi @sagikazarmark, I see that your are the first contributor to this repository, are you one of the maintainers? If so, could you have a look at this PR please? |
yann-soubeyrand
force-pushed
the
master
branch
2 times, most recently
from
65ce6f2 to
45fbe9b
Compare
When a config file is set using SetConfigFile: – WriteConfig failed if the file did not already exist, – SafeWriteConfig did not use it. Fixes spf13#430 Fixes spf13#433 Signed-off-by: Yann Soubeyrand <[email protected]>
yann-soubeyrand
force-pushed
the
master
branch
from
45fbe9b to
29bf0d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR makes WriteConfig work when the config file doesn't exist yet. In addition, it allows SafeWriteConfig to write the config to an explicitly set config file instead of the default config file. It also sets the config file used so that error messages can make use of it in case of error.
Fixes: #430
Fixes: #433