Skip default role check for multiline roles in tables #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that came up in python/devguide#1119 (see
sphinx-lintlog): when a link or a default role spans multiple lines in a table, it might get incorrectly reported, even if it's valid.Several checkers already have a similar condition to ignore tables, however adding the same condition has a few limitations:
Because of this, I made the check a bit more sophisticated, decreased the limit from >3 to >2 columns, added a test for the failure seen in the PR linked above, and an additional test to verify that invalid markup on a single line within the same cell is still detected. The other checkers should probably be updated too, possibly factoring out the condition.