ext.duration: fix merge_domaindata() #12251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
There is another level of
dictinotherdata, which wasn't immediately obvious to me.Detail
I didn't discover this by using
sphinx.ext.duration, but I copied this code to my own extension and witnessed the failure there.When I then tried
sphinx.ext.duration, the Sphinx build process got stuck (in a parallel build), but I don't know if that happens in all projects.I removed the type hint, because I'm quite sure it is wrong, but I don't know the right one.
Apparently, there is no test for this, but I also don't know how to create one.