Restore 'noindex' support for JS, Python domains

[stephenfin]

Feature or Bugfix

• Bugfix

Purpose

Fixes: e439c6f (Ensure that old-style object description options are respected (#12620))
Closes: #12843

Detail

• no-index ignored for :py:module: #12843

Note
Ideally this should be backport to the 7.x branch, but it appears we don't maintain stable branches any more?

Relates

None.

[picnixz]

Ideally this should be backport to the 7.x branch, but it appears we don't maintain stable branches any more?

Nope, we don't have backports (too much work and not enough hands...)

[picnixz]

Are these the only parts in the code base that require this? and could you perhaps add a test for that?

[stephenfin]

Are these the only parts in the code base that require this? and could you perhaps add a test for that?

I could, but I'm away for the next week and a bit so I'll be a while. I also don't know if it's essential given this is effectively continuing what was done in e439c6f through to completion and that didn't have tests. In addition, this is for a feature that will be deprecated soon and I have a reproducer linked in the bug that proves this fixes the issue, albeit manually. So maybe we can skirt around without one here and just get this in?

[AA-Turner]

I'll try and add a test later today, but I'm on a flight at some point so may not be that productive.

A

[stephenfin]

Thanks 🙏