Make :any: work with unknown object types in intersphinx. #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
requested changes
Nov 12, 2018
sir-sigurd
force-pushed
the
intersphinx-any
branch
from
1439275 to
c63a0c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #5598 +/- ##
==========================================
+ Coverage 83.22% 83.24% +0.02%
==========================================
Files 290 290
Lines 39345 39365 +20
Branches 5872 5872
==========================================
+ Hits 32744 32769 +25
+ Misses 5247 5245 -2
+ Partials 1354 1351 -3
Continue to review full report at Codecov.
|
|
@tk0miya, tests are fixed now. |
sir-sigurd
force-pushed
the
intersphinx-any
branch
from
c63a0c9 to
f12b37e
Compare
sir-sigurd
force-pushed
the
intersphinx-any
branch
from
f12b37e to
e22b183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Make
:any:work with unknown object types in intersphinxFeature or Bugfix
Feature
Purpose
As suggested in #5562 (comment), if you want to refer to some custom object type defined in foreign project you had to define it in your project which is inconvenient. It's needed because intersphinx searches foreign inventory only for registered object types. This PR makes
:any:role to not limit targets by registered object types.Relates