Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove old methods, change casing, add refreshDataset #195

Merged
merged 7 commits into from
Oct 15, 2024
Merged

feat: Remove old methods, change casing, add refreshDataset #195

merged 7 commits into from
Oct 15, 2024

Conversation

peasee
Copy link
Contributor

@peasee peasee commented Oct 9, 2024 •
edited
Loading

🗣 Description

  • Renames properties from SpiceClient, FlightInfo, FlightData, and SpiceClientConfig to follow camelCase naming convention
  • Updates locations where these properties were used, and general code, to camelCase
  • Removes getQueryResultsFromNotification, getQueryResultsAll, getQueryResults, and queryAsync functions from the SpiceClient as they target no longer supported SQL execution modes in the Spice Runtime.
  • Makes doQueryRequest private as it is an internal function.
  • Adds refreshDataset to refresh an accelerated dataset, with an associated test.
  • Removes webhook-associated tests and references in readme because they're no longer relevant.

🔨 Related Issues

@peasee peasee self-assigned this Oct 9, 2024
@peasee peasee mentioned this pull request Oct 15, 2024
Open
@peasee peasee requested a review from a team October 15, 2024 04:47
@peasee peasee added the enhancement New feature or request label Oct 15, 2024
@peasee peasee added this to the v3.0.0 milestone Oct 15, 2024
@peasee peasee marked this pull request as ready for review October 15, 2024 04:48
@peasee peasee mentioned this pull request Oct 15, 2024
Open
@peasee peasee merged commit 36afee5 into trunk Oct 15, 2024
10 checks passed
@peasee peasee deleted the feat/align-sdk branch October 15, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeadie Jeadie Jeadie approved these changes

Assignees

@peasee peasee

Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

task: Update SDK for feature parity
2 participants
@peasee @Jeadie