-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to show archived repos & archived
tag
#679
Conversation
archived
tagarchived
tag
archived
tagarchived
tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just some linting stuff.
What linter should I use to see the warnings? Eslint doesn't show any. And every formatter removes those spaces |
Co-authored-by: Isaac <[email protected]>
you are showing a regular js, not jsx |
It's in the |
I have committed suggestion for the |
Ah, maybe the ESLint rules don't apply to the tsx then, but I think it makes sense to follow the same conventions across both. |
Are you sure? JSX has different conventions. That's why eslint shows nothing |
It looks like it's an option. I'm sure there are different style guides, but I'm used to using spaces and regardless which we do, I think we should be consistent between js/jsx files in the same project. |
ew in jsx you shouldn't have curly spacing. looks bad af |
Literally looks the exact same as in JS. But okay if it's all done without spaces currently then I guess let's leave it. 🤷 |
tbh I have never seen JSX code with style like this. JS and JSX are not the same and shouldn't be connected with styles. JS has imports with curly spacing because that's how "it was designed" and JSX was designed to not have them |
No description provided.