-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the BundlePublisher interface #38
Conversation
Signed-off-by: Agustín Martínez Fayó <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to also include doc updates and a template (you can copy an existing one and adapt) all in the same PR. It will make the merge to main easier.
Signed-off-by: Agustín Martínez Fayó <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Introduce the BundlePublisher interface Signed-off-by: Agustín Martínez Fayó <[email protected]>
* Introduce the BundlePublisher interface Signed-off-by: Agustín Martínez Fayó <[email protected]>
Mention the BundlePublisher plugin type, and its built-in aws_s3 implementation, on the SPIRE Server Configuration Reference page. This plugin type was introduced in spiffe/spire-plugin-sdk#38. See also 2909, spiffe#4034. While I'm touching this, couple other tweaks: - Add CredentialComposer to plugin type list (its uniqueid implementation was already mentioned in the built-in plugin table). - Reorder the tables of plugin types and built-in plugins to hopefully make a little more sense, and to be consistent with each other. - Change a "sql" to a "SQL".
Mention the BundlePublisher plugin type, and its built-in aws_s3 implementation, on the SPIRE Server Configuration Reference page. This plugin type was introduced in spiffe/spire-plugin-sdk#38. See also 2909, spiffe#4034. While I'm touching this, couple other tweaks: - Add CredentialComposer to plugin type list (its uniqueid implementation was already mentioned in the built-in plugin table). - Reorder the tables of plugin types and built-in plugins to hopefully make a little more sense, and to be consistent with each other. - Change a "sql" to a "SQL".
Mention the BundlePublisher plugin type, and its built-in aws_s3 implementation, on the SPIRE Server Configuration Reference page. This plugin type was introduced in spiffe/spire-plugin-sdk#38. See also spiffe#2909, spiffe#4034. While I'm touching this, couple other tweaks: - Add CredentialComposer to plugin type list (its uniqueid implementation was already mentioned in the built-in plugin table). - Reorder the tables of plugin types and built-in plugins to hopefully make a little more sense, and to be consistent with each other. - Change a "sql" to a "SQL".
Mention the BundlePublisher plugin type, and its built-in aws_s3 implementation, on the SPIRE Server Configuration Reference page. This plugin type was introduced in spiffe/spire-plugin-sdk#38. See also spiffe#2909, spiffe#4034. While I'm touching this, a couple of other tweaks: - Add CredentialComposer to plugin type list (its uniqueid implementation was already mentioned in the built-in plugin table). - Reorder the tables of plugin types and built-in plugins to hopefully make a little more sense, and to be consistent with each other. - Change a "sql" to a "SQL".
Mention the BundlePublisher plugin type, and its built-in aws_s3 implementation, on the SPIRE Server Configuration Reference page. This plugin type was introduced in spiffe/spire-plugin-sdk#38. See also spiffe#2909, spiffe#4034. While I'm touching this, a couple of other tweaks: - Add CredentialComposer to plugin type list (its uniqueid implementation was already mentioned in the built-in plugin table). - Reorder the tables of plugin types and built-in plugins to hopefully make a little more sense, and to be consistent with each other. - Change a "sql" to a "SQL". Signed-off-by: Carlo Teubner <[email protected]>
Mention the BundlePublisher plugin type, and its built-in aws_s3 implementation, on the SPIRE Server Configuration Reference page. This plugin type was introduced in spiffe/spire-plugin-sdk#38. See also #2909, #4034. While I'm touching this, a couple of other tweaks: - Add CredentialComposer to plugin type list (its uniqueid implementation was already mentioned in the built-in plugin table). - Reorder the tables of plugin types and built-in plugins to hopefully make a little more sense, and to be consistent with each other. - Change a "sql" to a "SQL". Signed-off-by: Carlo Teubner <[email protected]>
Mention the BundlePublisher plugin type, and its built-in aws_s3 implementation, on the SPIRE Server Configuration Reference page. This plugin type was introduced in spiffe/spire-plugin-sdk#38. See also spiffe#2909, spiffe#4034. While I'm touching this, a couple of other tweaks: - Add CredentialComposer to plugin type list (its uniqueid implementation was already mentioned in the built-in plugin table). - Reorder the tables of plugin types and built-in plugins to hopefully make a little more sense, and to be consistent with each other. - Change a "sql" to a "SQL". Signed-off-by: Carlo Teubner <[email protected]>
Introduce the BundlePublisher interface. See this issue for more context.