Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the BundlePublisher interface #38

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

amartinezfayo
Copy link
Member

Introduce the BundlePublisher interface. See this issue for more context.

Signed-off-by: Agustín Martínez Fayó <[email protected]>
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to also include doc updates and a template (you can copy an existing one and adapt) all in the same PR. It will make the merge to main easier.

Signed-off-by: Agustín Martínez Fayó <[email protected]>
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amartinezfayo amartinezfayo merged commit 648f8c7 into spiffe:next Feb 24, 2023
azdagron pushed a commit that referenced this pull request May 17, 2023
* Introduce the BundlePublisher interface

Signed-off-by: Agustín Martínez Fayó <[email protected]>
azdagron pushed a commit that referenced this pull request May 18, 2023
* Introduce the BundlePublisher interface

Signed-off-by: Agustín Martínez Fayó <[email protected]>
c4rlo added a commit to c4rlo/spire that referenced this pull request Mar 6, 2024
Mention the BundlePublisher plugin type, and its built-in aws_s3
implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38.
See also 2909, spiffe#4034.

While I'm touching this, couple other tweaks:

- Add CredentialComposer to plugin type list (its uniqueid
  implementation was already mentioned in the built-in plugin table).
- Reorder the tables of plugin types and built-in plugins to hopefully
  make a little more sense, and to be consistent with each other.
- Change a "sql" to a "SQL".
c4rlo added a commit to c4rlo/spire that referenced this pull request Mar 6, 2024
Mention the BundlePublisher plugin type, and its built-in aws_s3
implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38.
See also 2909, spiffe#4034.

While I'm touching this, couple other tweaks:

- Add CredentialComposer to plugin type list (its uniqueid
  implementation was already mentioned in the built-in plugin table).
- Reorder the tables of plugin types and built-in plugins to hopefully
  make a little more sense, and to be consistent with each other.
- Change a "sql" to a "SQL".
c4rlo added a commit to c4rlo/spire that referenced this pull request Mar 6, 2024
Mention the BundlePublisher plugin type, and its built-in aws_s3
implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38.
See also spiffe#2909, spiffe#4034.

While I'm touching this, couple other tweaks:

- Add CredentialComposer to plugin type list (its uniqueid
  implementation was already mentioned in the built-in plugin table).
- Reorder the tables of plugin types and built-in plugins to hopefully
  make a little more sense, and to be consistent with each other.
- Change a "sql" to a "SQL".
c4rlo added a commit to c4rlo/spire that referenced this pull request Mar 6, 2024
Mention the BundlePublisher plugin type, and its built-in aws_s3
implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38.
See also spiffe#2909, spiffe#4034.

While I'm touching this, a couple of other tweaks:

- Add CredentialComposer to plugin type list (its uniqueid
  implementation was already mentioned in the built-in plugin table).
- Reorder the tables of plugin types and built-in plugins to hopefully
  make a little more sense, and to be consistent with each other.
- Change a "sql" to a "SQL".
c4rlo added a commit to c4rlo/spire that referenced this pull request Mar 6, 2024
Mention the BundlePublisher plugin type, and its built-in aws_s3
implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38.
See also spiffe#2909, spiffe#4034.

While I'm touching this, a couple of other tweaks:

- Add CredentialComposer to plugin type list (its uniqueid
  implementation was already mentioned in the built-in plugin table).
- Reorder the tables of plugin types and built-in plugins to hopefully
  make a little more sense, and to be consistent with each other.
- Change a "sql" to a "SQL".

Signed-off-by: Carlo Teubner <[email protected]>
amartinezfayo pushed a commit to spiffe/spire that referenced this pull request Mar 8, 2024
Mention the BundlePublisher plugin type, and its built-in aws_s3
implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38.
See also #2909, #4034.

While I'm touching this, a couple of other tweaks:

- Add CredentialComposer to plugin type list (its uniqueid
  implementation was already mentioned in the built-in plugin table).
- Reorder the tables of plugin types and built-in plugins to hopefully
  make a little more sense, and to be consistent with each other.
- Change a "sql" to a "SQL".

Signed-off-by: Carlo Teubner <[email protected]>
rushi47 pushed a commit to rushi47/spire that referenced this pull request Apr 11, 2024
Mention the BundlePublisher plugin type, and its built-in aws_s3
implementation, on the SPIRE Server Configuration Reference page.

This plugin type was introduced in spiffe/spire-plugin-sdk#38.
See also spiffe#2909, spiffe#4034.

While I'm touching this, a couple of other tweaks:

- Add CredentialComposer to plugin type list (its uniqueid
  implementation was already mentioned in the built-in plugin table).
- Reorder the tables of plugin types and built-in plugins to hopefully
  make a little more sense, and to be consistent with each other.
- Change a "sql" to a "SQL".

Signed-off-by: Carlo Teubner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants