Update grpc to v1.36.0 and proto to v1.26.0 #2175
Conversation
dragcp
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
rturner3
as code owners
|
Hmm, did |
Signed-off-by: ramand.dragcp <[email protected]> Add generate pb.go files Signed-off-by: ramand.dragcp <[email protected]>
|
Yes. "make generate" is not generating those files. I have now done "make generate-check" which generates the files and then fails. I have committed the generated files, rebased and repushed |
|
Thanks! |
|
Calling generate-check ( or protogen-check ) internally touches all the .proto files. Calling generate only picks up the proto files that have been touched by me. That is why it didn't regenerate the files in the first attempt |
|
Yeah, it's also supposed to regenerate when you move to a new version of the tool, but in your case, your build cache already had the new tool from working on the other PR, so it didn't rebuild. We're not really saving much time trying to be smart about regeneration since it is quick and idempotent. I'll probably tweak the makefile to just regenerate always. |
Signed-off-by: ramand.dragcp [email protected]
Pull Request check list
Affected functionality
This was split off from #2172
Description of change
We are upgrading the version of grpc and proto dependencies
Which issue this PR fixes