Sign images using Sigstore #3707
+20
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,19 +4,29 @@ on: | |||||
| # Random minute number to avoid GH scheduler stampede | ||||||
| - cron: '37 21 * * *' | ||||||
| workflow_dispatch: {} | ||||||
|
|
||||||
| env: | ||||||
| NIGHTLY: true | ||||||
|
|
||||||
| jobs: | ||||||
| build-and-publish-images: | ||||||
| runs-on: ubuntu-20.04 | ||||||
|
|
||||||
| permissions: | ||||||
| contents: read | ||||||
| id-token: write | ||||||
| packages: write | ||||||
|
|
||||||
| env: | ||||||
| COSIGN_EXPERIMENTAL: 1 | ||||||
|
|
||||||
| steps: | ||||||
| - name: Checkout | ||||||
| uses: actions/checkout@v3 | ||||||
|
There was a problem hiding this comment. a good practice is to use the git hash instead of the tag and have a comment to which release is pointing to. Dependabot when update the release can also update the comment :)
Suggested change
same applies to the other actions There was a problem hiding this comment. There is another PR adressing this practice already. #3727 |
||||||
| - name: Install cosign | ||||||
|
There was a problem hiding this comment. so, we'll be signing only release and nightly builds, how about regular builds images? (the ones generated when running PRs) There was a problem hiding this comment. agree, you can sign the image that you generate in the main branch build There was a problem hiding this comment. For that there is already a nightly in place. On the main branch no images are released, so also nothing to sign there. Or is there a way to sign an image that hasn't been pushed to a registry? Basically offline signature? I'm not aware you can sign without pushing to a registry. |
||||||
| uses: sigstore/[email protected] | ||||||
| with: | ||||||
| cosign-release: v1.13.1 | ||||||
| - name: Build images | ||||||
| run: make images scratch-images | ||||||
| - name: Log in to GCR | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,10 @@ jobs: | |
| cache-deps: | ||
| name: cache-deps (linux) | ||
| runs-on: ubuntu-20.04 | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -28,6 +32,10 @@ jobs: | |
| name: lint (linux) | ||
| runs-on: ubuntu-20.04 | ||
| needs: cache-deps | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -62,6 +70,10 @@ jobs: | |
| OS: [ubuntu-20.04, macos-latest] | ||
| runs-on: ${{ matrix.OS }} | ||
| needs: cache-deps | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -81,6 +93,10 @@ jobs: | |
| name: unit-test (linux with race detection) | ||
| runs-on: ubuntu-20.04 | ||
| needs: cache-deps | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -100,6 +116,10 @@ jobs: | |
| name: artifacts (linux) | ||
| runs-on: ubuntu-20.04 | ||
| needs: [cache-deps] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -131,6 +151,10 @@ jobs: | |
| name: images (linux) | ||
| runs-on: ubuntu-20.04 | ||
| needs: [cache-deps] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -164,6 +188,10 @@ jobs: | |
| name: images (windows) | ||
| runs-on: windows-2022 | ||
| needs: artifact-windows | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -187,6 +215,10 @@ jobs: | |
| scratch-images: | ||
| runs-on: ubuntu-20.04 | ||
| needs: [cache-deps] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -220,6 +252,10 @@ jobs: | |
| name: integration (linux) | ||
| runs-on: ubuntu-20.04 | ||
| needs: [cache-deps, images, scratch-images] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
@@ -287,6 +323,10 @@ jobs: | |
| name: integration (windows) | ||
| runs-on: windows-2022 | ||
| needs: images-windows | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: msys2 {0} | ||
|
|
@@ -334,6 +374,10 @@ jobs: | |
| cache-deps-windows: | ||
| name: cache-deps (windows) | ||
| runs-on: windows-2022 | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -353,6 +397,10 @@ jobs: | |
| name: lint (windows) | ||
| runs-on: windows-2022 | ||
| needs: cache-deps-windows | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: msys2 {0} | ||
|
|
@@ -396,6 +444,10 @@ jobs: | |
| name: unit-test (windows) | ||
| runs-on: windows-2022 | ||
| needs: cache-deps-windows | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: msys2 {0} | ||
|
|
@@ -428,6 +480,10 @@ jobs: | |
| name: artifact (windows) | ||
| runs-on: windows-2022 | ||
| needs: cache-deps-windows | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: msys2 {0} | ||
|
|
@@ -478,6 +534,10 @@ jobs: | |
| runs-on: ubuntu-20.04 | ||
| needs: [lint, unit-test, unit-test-race-detector, artifacts, integration, | ||
| lint-windows, unit-test-windows, artifact-windows, integration-windows] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -501,9 +561,22 @@ jobs: | |
| publish-images: | ||
| runs-on: ubuntu-20.04 | ||
| needs: [lint, unit-test, unit-test-race-detector, artifacts, integration] | ||
|
|
||
| permissions: | ||
| contents: read | ||
| id-token: write | ||
| packages: write | ||
|
|
||
| env: | ||
| COSIGN_EXPERIMENTAL: 1 | ||
marcofranssen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| - name: Install cosign | ||
| uses: sigstore/[email protected] | ||
| with: | ||
| cosign-release: v1.13.1 | ||
| - name: Download archived images | ||
| uses: actions/download-artifact@v3 | ||
| with: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this to use keyless approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, although experimental, haven't faced any issue in the last year I have been using it on various repos. I think they are close to making this feature GA, so with new release of cosign, this might not be required anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigstore is now GA so the env var here is no longer needed 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still required until we cut a cosign release v2