Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky endpoints test #3840

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

guilhermocc
Copy link
Contributor

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality
No functionality affected

Description of change
There is an extra error message that the server can respond to when trying to connect using a misconfigured foreign trust domain admin. This PR add this extra error assert.

Which issue this PR fixes
fixes #3839

Signed-off-by: Guilherme Carvalho <[email protected]>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @guilhermocc!

@amartinezfayo amartinezfayo merged commit 8815a2d into spiffe:main Feb 8, 2023
@azdagron azdagron added this to the 1.6.0 milestone Feb 9, 2023
stevend-uber pushed a commit to stevend-uber/spire that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky endpoints unit test
3 participants