Fix data race in agent manager tests #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
azdagron
force-pushed
the
fix-agent-manager-data-race
branch
2 times, most recently
from
8435209 to
f6d3dc5
Compare
Signed-off-by: Andrew Harding <[email protected]>
azdagron
force-pushed
the
fix-agent-manager-data-race
branch
from
f6d3dc5 to
0a6d907
Compare
MarcosDY
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entriesis not safe to access concurrently while logs are being written by another goroutine. This is causing failures in CI/CD. UsingAllEntries()instead, which is internally protected by a mutex.